Adopt package manager command classes - #1678
Closed
Eduardo Villalpando Mello (edvilme) wants to merge 3 commits into
Closed
Adopt package manager command classes#1678Eduardo Villalpando Mello (edvilme) wants to merge 3 commits into
Eduardo Villalpando Mello (edvilme) wants to merge 3 commits into
Conversation
This was referenced Jul 28, 2026
Eduardo Villalpando Mello (edvilme)
force-pushed
the
package-manager-command-adoption
branch
from
July 28, 2026 21:38
e1a77dd to
fddd48b
Compare
Eduardo Villalpando Mello (edvilme)
force-pushed
the
package-manager-command-adoption
branch
from
July 28, 2026 22:01
d25a1d1 to
2b9ae3c
Compare
Eduardo Villalpando Mello (edvilme)
force-pushed
the
package-manager-command-adoption
branch
from
July 28, 2026 22:14
2b9ae3c to
8ec3bba
Compare
Eduardo Villalpando Mello (edvilme)
force-pushed
the
package-manager-command-adoption
branch
from
July 28, 2026 22:20
8ec3bba to
6618b5d
Compare
Eduardo Villalpando Mello (edvilme)
force-pushed
the
package-manager-command-adoption
branch
from
July 28, 2026 22:42
6618b5d to
c9eeaff
Compare
Eduardo Villalpando Mello (edvilme)
added a commit
that referenced
this pull request
Jul 29, 2026
## Summary Introduces the reusable command-object layer for package management while leaving existing package-manager call sites unchanged. ## Scope - Adds the `PackageManagerCommand` base class and shared execution options. - Adds abstract templates for install, uninstall, list, version, available versions, and direct package names. - Adds concrete Pip/UV, Conda, and Poetry implementations. - Adds command factories, exports, and command-local execution helpers required by those implementations. - Preserves the existing executables, flags, environment targeting, prerelease defaults, and list-command timeouts. ## Non-goals This PR does not add command tests or migrate package managers to the new classes. Those changes are isolated in follow-up PRs #1677 and #1678. ## PR stack 1. This PR: command classes and implementations, based on `main`. 2. #1677: command smoke tests, based on this branch. 3. #1678: adoption and cleanup, based on #1677. ## Testing - `npm run lint` - `npm run compile-tests` - `npm run unittest` (1,448 passing, 4 pending)
Eduardo Villalpando Mello (edvilme)
force-pushed
the
package-manager-command-adoption
branch
from
July 31, 2026 21:01
c9eeaff to
a135bc8
Compare
Contributor
Author
|
Superseded by #1686, which targets main directly. Recreated to undo the GitHub-registered stack (base could not be retargeted). The branch is unchanged; only the PR base moved from package-manager-command-tests to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts the package manager command classes introduced in #1621 and covered by the smoke tests in #1677 across Pip/UV, Conda, and Poetry.
Changes
Dependency
This PR is stacked on #1677 and intentionally contains only the migration and cleanup commit. Review and merge #1621 and #1677 first; this PR can then be retargeted to
main.This replaces #1675, whose base branch could not be changed after GitHub registered it as part of the original stack.
Testing
npm run lintnpm run compile-testsnpm run unittest(1,451 passing, 4 pending)