Edit of Access for Owner, Contributor, and Reader.#141
Edit of Access for Owner, Contributor, and Reader.#141softcraftsman wants to merge 19 commits intomainfrom
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-ground-08f27020f-141.eastus2.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-pebble-03f47660f-141.eastus2.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-ground-08f27020f-141.eastus2.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-pebble-03f47660f-141.eastus2.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-ground-08f27020f-141.eastus2.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-pebble-03f47660f-141.eastus2.1.azurestaticapps.net |
There was a problem hiding this comment.
A few things we still need to plan:
- Improving the look of the header of the edit modal
- Displaying status messages after adding or deleting a role assignment
- Using strings.js for labels on EditDetails
- Feature flag
- Group membership providing "Owner" role
| } | ||
|
|
||
| if (req == null) | ||
| log.LogError("err"); |
There was a problem hiding this comment.
That doesn't seem like a useful error message?
| return new OkObjectResult(storageRbacEntry); | ||
| } | ||
|
|
||
| private static bool CanModifyRbac(RoleOperations roleOps, string accountResourceId, string container, string principalId) |
There was a problem hiding this comment.
Suggest abstracting this in a service class?
There was a problem hiding this comment.
This might not work if my Storage Blob Data Owner role is thanks to group membership.
| var roleAssignments = GetRoleAssignments(containerResourceId); | ||
| var authRoleAssignment = roleAssignments.FirstOrDefault(ra => ra.Id.EndsWith(rbacId)); | ||
| if (authRoleAssignment == null) | ||
| return null; |
There was a problem hiding this comment.
Should we throw an exception here?
| var roleAssignments = GetRoleAssignments(scope, principalId); | ||
|
|
||
| // Filter down to the specific role definition | ||
| var authRoleAssignment = roleAssignments?.FirstOrDefault(ra => ra.PrincipalId == principalId |
There was a problem hiding this comment.
Does GetRoleAssignments not already filter by principal ID? If not, why is it passed?
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-ground-08f27020f-141.eastus2.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-pebble-03f47660f-141.eastus2.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-ground-08f27020f-141.eastus2.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-pebble-03f47660f-141.eastus2.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-pebble-03f47660f-141.eastus2.1.azurestaticapps.net |
3 participants
No description provided.