Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Added prettier dependency and config - #26

Open
Ryan (chimon2000) wants to merge 1 commit into
microsoft:masterfrom
chimon2000:add_prettier
Open

Added prettier dependency and config#26
Ryan (chimon2000) wants to merge 1 commit into
microsoft:masterfrom
chimon2000:add_prettier

Conversation

@chimon2000

Copy link
Copy Markdown

Closes #6

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Oct 24, 2018

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

Comment thread package.json
"@types/react": "^16.0.21",
"@types/react-dom": "^16.0.2",
"css-loader": "^0.28.7",
"prettier": "1.14.3",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note sure if that is needed while there is no relevant script to run this. The VSCode/VS will pick the .prettierrc settings via built-in/extension

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If agreed, also yarn.lock shuld be reset

Comment thread .prettierrc
"singleQuote": true,
"tabWidth": 4,
"printWidth": 100
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the "parser": "typescript" valid option here?
https://prettier.io/docs/en/options.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants