Repository navigation
Conversation
The Optional Lint job has failed on every push to main for weeks. On push there is no PR diff, so reviewdog reports every pre-existing finding (~278); its log-annotation fallback errors out when more than 9 are reported, regardless of fail_level. - Run the job only on pull_request (both steps use the PR-check reporter). - Drop locale US so valid UK spellings (behaviour, cancelled, the CANCELLED status code, ...) aren't flagged. - Ignore false positives: NTO (NodesToOptimize alias), Spectre (the CPU vulnerability), interm (s390x MLAS variable). - Exclude .git, package-lock.json and vendored DocFX templates. - Use filter_mode added + fail_level any so new typos fail the PR instead of silently accumulating on main. The remaining 37 genuine typos are fixed in a separate PR. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the targeted pull-request spell-check changes.
No open issues 🎉
What changed in this PR
Updates Optional Lint so misspell checks focus on newly added PR content and fail on new typos without reporting known false positives.
Changes:
- Runs Optional Lint only for pull requests.
- Accepts US and UK spellings, ignores three known false positives, and excludes Git metadata, lockfiles, and vendored DocFX templates.
- Uses added-line filtering and fails the misspell step on any reported finding.
| File | Description |
|---|---|
.github/workflows/lint.yml |
Restricts Optional Lint to PRs and configures targeted, blocking spell checks. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reconfigures the
misspellstep of the Optional Lint job in.github/workflows/lint.yml:optional-lintjob only onpull_request(both of its steps use reviewdog'sgithub-pr-checkreporter).locale: "US"so valid UK spellings (behaviour,cancelled, the publicCANCELLEDstatus code, ...) are accepted.nto(NTO = NodesToOptimizealias in optimizer code),spectre(the CPU vulnerability, flagged as a UK spelling of "specter"),interm(s390x MLAS variable)..git,package-lock.json, and the vendored/minified DocFX templates undercsharp/ApiDocs/_exported_templates.filter_mode: added+fail_level: anyso new typos fail the PR check instead of accumulating onmain.The remaining 37 genuine typos on
mainare fixed in a companion PR.Validation (local, using the checksum-verified golangci/misspell v0.8.0 Windows binary, the version pinned in the action's Docker image, over
git ls-files):-locale US): 280 findings, matching CI's 278 (reported too many annotation (N=278)).-i nto,spectre,interm, same excludes): 37 findings, all genuine typos (fixed in the companion PR).find . -not -path ...(Git Bash): no.git/,package-lock.json, ordocfx.vendor.jspaths remain.python -c "import yaml; yaml.safe_load(open('.github/workflows/lint.yml'))": passed.Motivation and Context
Every push to
mainproduces a Lint failure email (300+ consecutive failed runs, e.g. https://github.com/microsoft/onnxruntime/actions/runs/41116362817). On push there is no PR diff, sofilter_mode: diff_contextfilters nothing and misspell reports every existing finding repo-wide. reviewdog then falls back to log annotations, and itsGitHubActionLogWriter.Flushreturns an error whenever more than 9 results are reported (reviewdog: Too many results (annotations) in diff/reported too many annotation (N=278)), regardless offail_level. TheOptional Lint C++job hits the same error but is masked bycontinue-on-error: true.