Skip to content

Fix build break on Windows runner - #1433

Merged
Branden Bonaby (bbonaby) merged 1 commit into
mainfrom
user/bbonaby/fix-windows-build-break
Oct 7, 2026
Merged

Branden Bonaby (bbonaby) merged 1 commit into
mainfrom
user/bbonaby/fix-windows-build-break

Conversation

@bbonaby

@bbonaby Branden Bonaby (bbonaby) commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

📖 Description

  • Remove the obsolete builtin_test_server field from the Windows PSEC proxy test helper's ProxyConfig initializer.
  • Restore Windows test compilation and Clippy without changing runtime behavior.

🔗 References

🔍 Validation

Commands run from src/:

  • cargo check -p mxc-sdk --tests --locked — reproduced E0560 before the fix; passed afterward.
  • cargo fmt --all -- --check — passed.
  • cargo clippy -p mxc-sdk --all-targets --locked -- -D warnings — passed.
  • cargo test -p mxc-sdk --lib --locked psec_1_0 -- --test-threads=1 — passed, 7 tests.

No real sandbox workloads were run. Windows ARM64 and the full release/all-features CI matrix were not run locally.

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task

GitHub Actions runs the PR validation build automatically. The ADO pipeline
(MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHub
Actions build; it runs on merge to main, and Microsoft reviewers with write access can trigger it
on a PR with /azp run. See pull request builds.

If the dependency-feed-check check fails on a new dependency, the crate must be added to
the feed before the PR can pass. See pull request builds
for the steps.

Microsoft Reviewers: Open in CodeFlow

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d91c468f-e7d6-4cfd-a21d-d01f30f2ae69
Copilot AI balanced review requested due to automatic review settings October 7, 2026 00:51
@bbonaby
Branden Bonaby (bbonaby) requested a review from a team as a code owner October 7, 2026 00:51
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The test-only removal matches the current struct definition, with no unresolved issues.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes Windows proxy test compilation by aligning the test helper with the current ProxyConfig definition.

Changes:

  • Removes the obsolete builtin_test_server initializer field without changing runtime behavior.
File Description
src/​mxc-sdk/​src/​backends/​process_container/​common/​base_container_runner.rs Removes an obsolete field from the proxy test helper.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bbonaby Branden Bonaby (bbonaby) changed the title Fix Windows proxy test compilation Fix build break on Windows runner Oct 7, 2026
@MGudgin Gudge (MGudgin) mentioned this pull request Oct 7, 2026
@bbonaby
Branden Bonaby (bbonaby) merged commit 7e35c32 into main Oct 7, 2026
31 checks passed
@bbonaby
Branden Bonaby (bbonaby) deleted the user/bbonaby/fix-windows-build-break branch October 7, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants