Repository navigation
Fix build break on Windows runner - #1433
Merged
Branden Bonaby (bbonaby) merged 1 commit intoOct 7, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d91c468f-e7d6-4cfd-a21d-d01f30f2ae69
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The test-only removal matches the current struct definition, with no unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes Windows proxy test compilation by aligning the test helper with the current ProxyConfig definition.
Changes:
- Removes the obsolete
builtin_test_serverinitializer field without changing runtime behavior.
| File | Description |
|---|---|
src/mxc-sdk/src/backends/process_container/common/base_container_runner.rs |
Removes an obsolete field from the proxy test helper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Gudge (MGudgin)
approved these changes
Oct 7, 2026
Closed
Branden Bonaby (bbonaby)
deleted the
user/bbonaby/fix-windows-build-break
branch
October 7, 2026 02:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
builtin_test_serverfield from the Windows PSEC proxy test helper'sProxyConfiginitializer.🔗 References
🔍 Validation
Commands run from
src/:cargo check -p mxc-sdk --tests --locked— reproducedE0560before the fix; passed afterward.cargo fmt --all -- --check— passed.cargo clippy -p mxc-sdk --all-targets --locked -- -D warnings— passed.cargo test -p mxc-sdk --lib --locked psec_1_0 -- --test-threads=1— passed, 7 tests.No real sandbox workloads were run. Windows ARM64 and the full release/all-features CI matrix were not run locally.
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see pull request builds)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See pull request builds.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See pull request builds
for the steps.
Microsoft Reviewers: Open in CodeFlow