Fix crates release pipeline template paths - #1404
Merged
Branden Bonaby (bbonaby) merged 1 commit intoOct 6, 2026
Merged
Branden Bonaby (bbonaby) merged 1 commit into
Branden Bonaby (bbonaby) merged 1 commit into
Conversation
Resolve release job templates from the repository root so Azure Pipelines can load them during YAML validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 433e5b70-c2bd-496d-9b8d-bd2085bb2706
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Both corrected paths exist and match the established pipeline convention.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes Azure DevOps validation by resolving crate job templates from the repository root.
Changes:
- Uses absolute
@selfpaths for both crate release job templates. - Aligns with the existing Isolation Session pipeline convention.
| File | Description |
|---|---|
.azure-pipelines/1ES.Release.Crates.yml |
Corrects package and publish template paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jeff Whiteside (jsidewhite)
approved these changes
Oct 6, 2026
Anis Mohammed Khaja Mohideen (kanismohammed)
approved these changes
Oct 6, 2026
Branden Bonaby (bbonaby)
deleted the
user/bbonaby/fix-crates-release-template-paths
branch
October 6, 2026 07:18
1 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Could not find /templates/Package.Crates.Job.yml.@selfpath convention used by the existing Isolation Session pipeline.🔗 References
🔍 Validation
pwsh -NoProfile -File scripts/ci/Invoke-CratePackage.ps1 -ValidateOnly— passed.git diff --check— passed.✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See docs/pull-requests.md.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See docs/pull-requests.md
for the steps.
Microsoft Reviewers: Open in CodeFlow