Add progress bar to checkpoint download#157
Merged
Merged
Conversation
Use streaming download with tqdm progress bar in download_file() so users can see download progress (file size, speed, ETA) instead of the process appearing to hang during first-time checkpoint downloads. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
@copilot review this PR |
Contributor
I reviewed this PR and re-checked the download path; no further changes are needed from my side. The current implementation in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the calculator downloads pretrained checkpoints for the first time,
download_file()usesrequests.get(url)which loads the entire file into memory with no progress indication. For large checkpoint files, this makes it appear as if the process is stuck.Fix
stream=True+ chunked writing)tqdmprogress bar showing filename, downloaded/total size, speed, and ETAtqdmis already a dependency used elsewhere in the codebase