Repository navigation
Test download table reproducibility instead of Windows signatures - #2726
Merged
Davis Goodin (dagood) merged 1 commit intoNov 13, 2026
Merged
Davis Goodin (dagood) merged 1 commit into
Davis Goodin (dagood) merged 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot CLI created this pull request from a session on behalf of
Davis Goodin (dagood)
November 13, 2026 17:32
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the download-table reproducibility test change.
No open issues 🎉
What changed in this PR
This PR replaces Windows archive signature assertions with a reproducibility check for the generated download table, aligning it with other generated-document tests.
Changes:
- Compare the generated section of
eng/doc/Downloads.mdwith the current link-table generator output. - Normalize checkout line endings and validate section markers.
- Report the regeneration command when the content differs.
| File | Description |
|---|---|
eng/_util/cmd/updatelinktable/updatelinktable_test.go |
Replace signature-specific checks with a download-table reproducibility test. |
Review effort: Balanced
Quim Muntal (qmuntal)
approved these changes
Nov 13, 2026
Davis Goodin (dagood)
enabled auto-merge (squash)
November 13, 2026 18:27
Davis Goodin (dagood)
deleted the
dev/dagood/updatelinktable-reproducibility
branch
November 13, 2026 19:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the fragile Windows archive signature assertions with a reproducibility test comparing the generated section of
eng/doc/Downloads.mdagainst the current link-table generator output.Normalize checkout line endings and report the regeneration command on mismatch, following the other generated-document tests.
Validation:
cd eng/_util && go test ./cmd/updatelinktable.