Skip to content

Test download table reproducibility instead of Windows signatures - #2726

Merged
Davis Goodin (dagood) merged 1 commit into
microsoft/mainfrom
dev/dagood/updatelinktable-reproducibility
Nov 13, 2026
Merged

Davis Goodin (dagood) merged 1 commit into
microsoft/mainfrom
dev/dagood/updatelinktable-reproducibility

Conversation

Copilot AI commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Replace the fragile Windows archive signature assertions with a reproducibility test comparing the generated section of eng/doc/Downloads.md against the current link-table generator output.

Normalize checkout line endings and report the regeneration command on mismatch, following the other generated-document tests.

Validation: cd eng/_util && go test ./cmd/updatelinktable.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@dagood
Davis Goodin (dagood) marked this pull request as ready for review November 13, 2026 17:49
@dagood
Davis Goodin (dagood) requested a review from a team as a code owner November 13, 2026 17:49
Copilot AI balanced review requested due to automatic review settings November 13, 2026 17:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the download-table reproducibility test change.

No open issues 🎉

What changed in this PR

This PR replaces Windows archive signature assertions with a reproducibility check for the generated download table, aligning it with other generated-document tests.

Changes:

  • Compare the generated section of eng/doc/Downloads.md with the current link-table generator output.
  • Normalize checkout line endings and validate section markers.
  • Report the regeneration command when the content differs.
File Description
eng/​_util/​cmd/​updatelinktable/​updatelinktable_test.go Replace signature-specific checks with a download-table reproducibility test.

Review effort: Balanced

@dagood
Davis Goodin (dagood) enabled auto-merge (squash) November 13, 2026 18:27
@dagood
Davis Goodin (dagood) merged commit 9b35cc8 into microsoft/main Nov 13, 2026
76 checks passed
@dagood
Davis Goodin (dagood) deleted the dev/dagood/updatelinktable-reproducibility branch November 13, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants