Skip to content

Allow CI to test alternate Go submodule revisions - #2690

Merged
Quim Muntal (qmuntal) merged 11 commits into
microsoft/mainfrom
copilot/add-ci-submodule-commit-option
Nov 17, 2026
Merged

Quim Muntal (qmuntal) merged 11 commits into
microsoft/mainfrom
copilot/add-ci-submodule-commit-option

Conversation

Copilot AI commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Testing upstream CLs currently requires a branch or patch change. Add manual CI parameters to select a different Go revision without modifying the repository.

  • Revision override: Add submoduleRef to PR and rolling pipelines, accepting a commit SHA or Gerrit ref. Default nil preserves the pinned commit.
  • Custom source: Public PR pipelines accept submoduleRepository; overrides otherwise fetch anonymously from https://go.googlesource.com/go.
  • Patching: Stage the selected gitlink so subsequent refreshes preserve it. Microsoft patches remain enabled, including on fresh-agent retries.

Example manual-run parameters:

submoduleRef: refs/changes/34/123434/2
submoduleRepository: https://go.googlesource.com/go

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI and others added 2 commits November 3, 2026 12:42
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Copilot AI changed the title [WIP] Add option to run CI with different submodule commit Allow CI to test alternate Go submodule revisions Nov 3, 2026
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Copilot AI and others added 2 commits November 3, 2026 14:09
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
@qmuntal
Quim Muntal (qmuntal) requested a review from a team as a code owner November 3, 2026 14:16
Copilot AI balanced review requested due to automatic review settings November 3, 2026 14:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The retry job re-resolves moving submodule refs instead of reusing the build’s resolved SHA, potentially mixing newer sources with an older compiled toolchain.

2 open issues
What changed in this PR

Adds manual Go submodule revision overrides to PR and rolling CI pipelines, enabling upstream change testing without modifying the repository’s pinned revision.

Changes:

  • Adds submoduleRef parameters and a custom source option for public PR pipelines.
  • Fetches and stages the selected revision so later refreshes preserve it while applying Microsoft patches.
  • Documents CI usage and local override/reset commands.
File Description
eng/​README.md Documents local revision overrides and resetting the staged gitlink.
eng/​pipeline/​steps/​init-submodule-task.yml Adds anonymous override fetching while preserving default mirror behavior.
eng/​pipeline/​stages/​run-stage.yml Passes override context to build and fresh-agent retry initialization.
eng/​pipeline/​rolling.gen.yml Adds revision selection to the rolling pipeline generator.
eng/​pipeline/​rolling-pipeline.yml Exposes revision selection for rolling outerloop runs.
eng/​pipeline/​rolling-innerloop-pipeline.yml Exposes revision selection for rolling innerloop runs.
eng/​pipeline/​README.md Documents manual CI overrides and source restrictions.
eng/​pipeline/​pr.gen.yml Adds revision and source parameters to the PR pipeline generator.
eng/​pipeline/​pr-pipeline.yml Exposes override parameters for PR innerloop runs.
eng/​pipeline/​pr-outerloop-pipeline.yml Exposes override parameters for PR outerloop runs.
eng/​_util/​cmd/​submodule-refresh/​submodule-refresh.go Implements fetching, checkout, and staging of an override revision.

Review effort: Balanced

Comment thread eng/pipeline/stages/run-stage.yml Resolved
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
@qmuntal
Quim Muntal (qmuntal) marked this pull request as draft November 3, 2026 14:47
@qmuntal
Quim Muntal (qmuntal) marked this pull request as ready for review November 3, 2026 14:47
Comment thread eng/pipeline/stages/run-stage.yml Resolved
Comment thread eng/pipeline/README.md Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread eng/doc/DeveloperGuide.md Resolved
Comment thread eng/doc/DeveloperGuide.md Resolved
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
@qmuntal
Quim Muntal (qmuntal) merged commit fc92e6a into microsoft/main Nov 17, 2026
75 checks passed
@qmuntal
Quim Muntal (qmuntal) deleted the copilot/add-ci-submodule-commit-option branch November 17, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to run CI with a different submodule commit to test upstream CLs

5 participants