Repository navigation
Allow CI to test alternate Go submodule revisions - #2690
Merged
Quim Muntal (qmuntal) merged 11 commits intoNov 17, 2026
Merged
Quim Muntal (qmuntal) merged 11 commits into
Quim Muntal (qmuntal) merged 11 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add option to run CI with different submodule commit
Allow CI to test alternate Go submodule revisions
Nov 3, 2026
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The retry job re-resolves moving submodule refs instead of reusing the build’s resolved SHA, potentially mixing newer sources with an older compiled toolchain.
2 open issues
What changed in this PR
Adds manual Go submodule revision overrides to PR and rolling CI pipelines, enabling upstream change testing without modifying the repository’s pinned revision.
Changes:
- Adds
submoduleRefparameters and a custom source option for public PR pipelines. - Fetches and stages the selected revision so later refreshes preserve it while applying Microsoft patches.
- Documents CI usage and local override/reset commands.
| File | Description |
|---|---|
| eng/README.md | Documents local revision overrides and resetting the staged gitlink. |
| eng/pipeline/steps/init-submodule-task.yml | Adds anonymous override fetching while preserving default mirror behavior. |
| eng/pipeline/stages/run-stage.yml | Passes override context to build and fresh-agent retry initialization. |
| eng/pipeline/rolling.gen.yml | Adds revision selection to the rolling pipeline generator. |
| eng/pipeline/rolling-pipeline.yml | Exposes revision selection for rolling outerloop runs. |
| eng/pipeline/rolling-innerloop-pipeline.yml | Exposes revision selection for rolling innerloop runs. |
| eng/pipeline/README.md | Documents manual CI overrides and source restrictions. |
| eng/pipeline/pr.gen.yml | Adds revision and source parameters to the PR pipeline generator. |
| eng/pipeline/pr-pipeline.yml | Exposes override parameters for PR innerloop runs. |
| eng/pipeline/pr-outerloop-pipeline.yml | Exposes override parameters for PR outerloop runs. |
| eng/_util/cmd/submodule-refresh/submodule-refresh.go | Implements fetching, checkout, and staging of an override revision. |
Review effort: Balanced
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Quim Muntal (qmuntal)
marked this pull request as draft
November 3, 2026 14:47
Quim Muntal (qmuntal)
marked this pull request as ready for review
November 3, 2026 14:47
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Quim Muntal (qmuntal)
enabled auto-merge
November 16, 2026 13:26
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
George Adams (gdams)
approved these changes
Nov 17, 2026
Quim Muntal (qmuntal)
deleted the
copilot/add-ci-submodule-commit-option
branch
November 17, 2026 09:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Testing upstream CLs currently requires a branch or patch change. Add manual CI parameters to select a different Go revision without modifying the repository.
submoduleRefto PR and rolling pipelines, accepting a commit SHA or Gerrit ref. Defaultnilpreserves the pinned commit.submoduleRepository; overrides otherwise fetch anonymously fromhttps://go.googlesource.com/go.Example manual-run parameters: