Repository navigation
Document crypto/x509 in the FIPS User Guide - #2661
Merged
Quim Muntal (qmuntal) merged 2 commits intoOct 28, 2026
Merged
Quim Muntal (qmuntal) merged 2 commits into
Quim Muntal (qmuntal) merged 2 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add crypto/x509 to FIPS User Guide
Document crypto/x509 in the FIPS User Guide
Oct 28, 2026
Quim Muntal (qmuntal)
marked this pull request as ready for review
October 28, 2026 13:18
Quim Muntal (qmuntal)
enabled auto-merge
October 28, 2026 13:18
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the added crypto/x509 FIPS guidance.
No open issues 🎉
What changed in this PR
Adds dedicated crypto/x509 coverage to the FIPS User Guide, addressing issue #694 by explaining how its APIs depend on FIPS-sensitive cryptographic primitives.
Changes:
- Documents certificate, CSR, and CRL signing and verification, including custom signers and platform verification.
- Clarifies parsing and trust boundaries and warns against legacy PEM encryption for FIPS-approved key protection.
- Registers the package, regenerates the guide, and adds heading and table-of-contents coverage checks.
| File | Description |
|---|---|
eng/doc/fips/UserGuide.md |
Adds generated x509 guidance and table-of-contents entries. |
eng/_util/cmd/updatecryptodocs/userguide_content.go |
Defines the x509 guidance in the structured documentation source. |
eng/_util/cmd/updatecryptodocs/updatecryptodocs_test.go |
Checks x509 API headings and table-of-contents entries. |
eng/_util/cmd/updatecryptodocs/packages.go |
Registers x509 as a User Guide package. |
Review effort: Balanced
George Adams (gdams)
approved these changes
Oct 28, 2026
Quim Muntal (qmuntal)
deleted the
copilot/add-crypto-x509-to-fips-user-guide
branch
October 28, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FIPS User Guide mentions
crypto/x509only in the TLS context, leaving its own APIs undocumented despite their reliance on FIPS-sensitive crypto primitives.