Skip to content

[release-branch.go1.27] crypto/tls: prefer backend-supported signature algorithms - #2647

Merged
Quim Muntal (qmuntal) merged 1 commit into
microsoft/release-branch.go1.27from
dev/qmuntal/go1.27-tls-signature-backend-preference
Oct 28, 2026
Merged

Quim Muntal (qmuntal) merged 1 commit into
microsoft/release-branch.go1.27from
dev/qmuntal/go1.27-tls-signature-backend-preference

Conversation

@qmuntal

Copy link
Copy Markdown
Member

Backport of #2646.

Summary

  • Prefer backend-supported signature schemes under the active Microsoft TLS profile for both signature_algorithms and signature_algorithms_cert, preserving relative order within supported and fallback groups.
  • Retain upstream ordering with ms_tlsprofile=off or pure-Go builds, without removing fallback algorithms.
  • Adjust the Go 1.27-specific ms_tlsmldsacert wire test to account for the active profile's signature order while preserving its opt-out coverage.

Validation

  • Built the patched Go 1.27.3 toolchain on Windows ARM64.
  • Focused TLS and dependency tests passed in native CNG and pure-Go modes (MS_GO_NOSYSTEMCRYPTO=0 and 1), including the release-specific certificate-advertisement test.
  • Verified both regenerated patches reproduce their target commit trees exactly and match the patch-index hashes.

…e algorithms

Backport #2646 (60040a4). Preserve the release-specific certificate-signature advertisement test by accounting for backend preference ordering.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 28, 2026 08:23
@qmuntal
Quim Muntal (qmuntal) requested a review from a team as a code owner October 28, 2026 08:23
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the Go 1.27 TLS signature-ordering backport.

No open issues 🎉

What changed in this PR

Backports #2646 to Go 1.27, preferring backend-supported TLS signature schemes under the active Microsoft profile while retaining fallback algorithms and upstream ordering for opt-out and pure-Go builds.

Changes:

  • Reuses stable preference sorting for signature algorithms and key-exchange groups.
  • Adds signature-ordering coverage and adjusts the Go 1.27 certificate-advertisement test.
  • Updates patch hashes and index metadata.

Patches are happy!

File Description
patches/​index.json Refreshes hashes and index entries for the regenerated patches.
patches/​0013-Add-ms_tlsmldsacert-GODEBUG-setting.patch Makes certificate-advertisement expectations profile-aware while preserving opt-out coverage.
patches/​0010-Align-TLS-settings-with-Microsoft-policies.patch Adds backend-aware signature ordering and tests across capabilities, profiles, and TLS versions.

Review effort: Balanced

@qmuntal
Quim Muntal (qmuntal) merged commit c2f359e into microsoft/release-branch.go1.27 Oct 28, 2026
61 checks passed
@qmuntal
Quim Muntal (qmuntal) deleted the dev/qmuntal/go1.27-tls-signature-backend-preference branch October 28, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants