Repository navigation
[release-branch.go1.27] crypto/tls: prefer backend-supported signature algorithms - #2647
Merged
Quim Muntal (qmuntal) merged 1 commit intoOct 28, 2026
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
George Adams (gdams)
approved these changes
Oct 28, 2026
Quim Muntal (qmuntal)
enabled auto-merge
October 28, 2026 08:25
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the Go 1.27 TLS signature-ordering backport.
No open issues 🎉
What changed in this PR
Backports #2646 to Go 1.27, preferring backend-supported TLS signature schemes under the active Microsoft profile while retaining fallback algorithms and upstream ordering for opt-out and pure-Go builds.
Changes:
- Reuses stable preference sorting for signature algorithms and key-exchange groups.
- Adds signature-ordering coverage and adjusts the Go 1.27 certificate-advertisement test.
- Updates patch hashes and index metadata.
Patches are happy!
| File | Description |
|---|---|
| patches/index.json | Refreshes hashes and index entries for the regenerated patches. |
| patches/0013-Add-ms_tlsmldsacert-GODEBUG-setting.patch | Makes certificate-advertisement expectations profile-aware while preserving opt-out coverage. |
| patches/0010-Align-TLS-settings-with-Microsoft-policies.patch | Adds backend-aware signature ordering and tests across capabilities, profiles, and TLS versions. |
Review effort: Balanced
Quim Muntal (qmuntal)
merged commit Oct 28, 2026
c2f359e
into
microsoft/release-branch.go1.27
61 checks passed
Quim Muntal (qmuntal)
deleted the
dev/qmuntal/go1.27-tls-signature-backend-preference
branch
October 28, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2646.
Summary
signature_algorithmsandsignature_algorithms_cert, preserving relative order within supported and fallback groups.ms_tlsprofile=offor pure-Go builds, without removing fallback algorithms.ms_tlsmldsacertwire test to account for the active profile's signature order while preserving its opt-out coverage.Validation
MS_GO_NOSYSTEMCRYPTO=0and1), including the release-specific certificate-advertisement test.