Repository navigation
FIPS readme updates, clarify GOFIPS - #2003
Merged
Merged
Conversation
Davis Goodin (dagood)
force-pushed
the
dev/dagood/fips-readme
branch
from
December 12, 2025 21:59
682b7ef to
9ba173c
Compare
Davis Goodin (dagood)
force-pushed
the
dev/dagood/fips-readme
branch
from
December 12, 2025 22:02
9ba173c to
2236a24
Compare
Martijn Verburg (karianna)
approved these changes
Dec 12, 2025
Martijn Verburg (karianna)
left a comment
Member
There was a problem hiding this comment.
Looks fine overall, looking forward to a day where we can archive the variations!
Quim Muntal (qmuntal)
approved these changes
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GOFIPS=asdfmeaning thatsystemFIPSMode()won't be called. It's also possible I misinterpreted it or we'll want to change it--please take a look at this, Quim Muntal (@qmuntal).https://github.com/microsoft/go/blob/microsoft/release-branch.go1.25/patches/0003-Implement-crypto-internal-backend.patch#L1748
https://github.com/microsoft/go/blob/microsoft/release-branch.go1.24/patches/0003-Implement-crypto-internal-backend.patch#L1750