Repository navigation
getmingw: support selecting the latest Nixman version - #698
Open
Michelle Clayton (michelle-clayton-work) wants to merge 1 commit into
Open
Michelle Clayton (michelle-clayton-work) wants to merge 1 commit into
Michelle Clayton (michelle-clayton-work) wants to merge 1 commit into
Conversation
Add run -latest to select the highest matching GCC, runtime and revision while preserving existing ambiguity checks for equally new build variants. This supports testing Go with the newest catalog compiler alongside the pinned compiler. Related to microsoft/go-lab#496 and microsoft/go#2701. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michelle Clayton (michelle-clayton-work)
requested a review
from a team
as a code owner
November 16, 2026 23:57
Copilot started reviewing on behalf of
Michelle Clayton (michelle-clayton-work)
November 16, 2026 23:57
Michelle Clayton (michelle-clayton-work)
requested a review
from Davis Goodin (dagood)
November 16, 2026 23:58
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the optional latest-version selection change.
No open issues 🎉
What changed in this PR
Adds optional latest-version selection to getmingw run, supporting downstream Go builds with the newest matching Nixman compiler while preserving behavior when -latest is omitted.
Changes:
- Selects builds after existing filters using numeric GCC version, runtime version, and revision.
- Preserves equally new variants for existing ambiguity checks and rejects unsupported sources or malformed versions.
- Adds tests for numeric ordering, tied variants, malformed versions, overflow, and unsupported sources.
| File | Description |
|---|---|
cmd/getmingw/run.go |
Adds the -latest flag and Nixman version selection logic. |
cmd/getmingw/main_test.go |
Tests latest-version selection and validation errors. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getmingw run -latestto select the newest matching Nixman catalog version by numeric GCC version, runtime version, and revision.-latestis omitted.This is the helper change for microsoft/go#2701, which will build and test Go with both the pinned compiler and the newest matching catalog compiler. That PR needs a dependency bump after this change is merged and available to consume.
Related to https://github.com/microsoft/go-lab/issues/496.
Validation
go test ./cmd/getmingw -count=1golangci-lint run ./cmd/getmingwgit diff --checkFocused tests cover numeric ordering, equal-version variants, malformed versions, numeric overflow, and unsupported sources.