Repository navigation
goinstallscript: verify archive signatures with GnuPG - #693
Open
Quim Muntal (qmuntal) wants to merge 4 commits into
Open
Quim Muntal (qmuntal) wants to merge 4 commits into
Quim Muntal (qmuntal) wants to merge 4 commits into
Conversation
Use an embedded Microsoft key and an isolated keyring when GnuPG is available. Warn and retain SHA-256-only checks otherwise, with -RequireSignature for fail-closed installs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the installer signature-verification changes.
No open issues 🎉
What changed in this PR
Adds OpenPGP signature verification to the PowerShell Go installer using an embedded Microsoft public key, while retaining mandatory SHA-256 checks.
Changes:
- Verify signatures with GnuPG in an isolated temporary keyring; warn when GnuPG is absent or fail with
-RequireSignature. - Preserve dry runs and installed-version reuse, and correctly render switch parameters in repeatable commands.
- Document verification policy and expand tests for failures, cleanup, keyring isolation, and published signatures.
| File | Description |
|---|---|
goinstallscript/README-InstallScript.md |
Documents verification requirements, fallback behavior, and unsigned-release limitations. |
goinstallscript/powershell/powershell_test.go |
Extends installer tests for signature handling and required verification. |
goinstallscript/powershell/gpg_test.go |
Adds key, GnuPG, isolation, cleanup, and tampering tests. |
goinstallscript/powershell/go-install.ps1 |
Implements signature verification, temporary-file cleanup, and switch rendering. |
Review effort: Balanced
George Adams (gdams)
approved these changes
Nov 13, 2026
George Adams (gdams)
left a comment
Member
There was a problem hiding this comment.
Looks sane but I'll let Davis Goodin (@dagood) confirm
Davis Goodin (dagood)
requested changes
Nov 13, 2026
Davis Goodin (dagood)
left a comment
Member
There was a problem hiding this comment.
Will need reconciling with #694, but the feature itself seems reasonable.
Merge main to reconcile #694. Keep signature verification documentation focused on -RequireSignature under Usage and make GnuPG optional for normal installs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Quim Muntal (qmuntal)
enabled auto-merge
November 16, 2026 11:13
Member
Author
|
Copilot remove this warning: #693 (comment). |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Contributor
Removed the warning, updated the parameter help, and added a regression assertion. Tests pass. Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-RequireSignatureto fail instead. Missing or invalid signatures and GnuPG errors never trigger fallback.Validation
-RequireSignatureand real GnuPG.git diff --checkpassed.