PS: Add a query for CWE-494#371
Open
MathiasVP wants to merge 9 commits into
Open
Conversation
|
what do you think about looking for flow to Get-AuthenticodeSignature as well? |
|
Campaign run (including Get-AuthenticodeSignature sink): https://codeql.microsoft.com/campaigns/run?Run=4e1370b99c694d3097daecb02076a912__c8e67a5b-9552-45b7-9e69-020d74ea6961 |
…ates, isAdditionalFlowStep to fix fp case
|
Campaign run with expanded query: https://codeql.microsoft.com/campaigns/run?Run=bf003eba007040238a8ae389901c359e__67e2de6e-268f-4515-ad16-cf4b25b53b0e |
…l along) and replace ad-hoc additional steps with flow summaries.
Collaborator
Author
|
Thanks for extending the query (and running a campaign)! I've cleaned up the query a bit and reverted a change I disagree with in 067711a (see my comments on Teams regarding this). |
rashworld-max
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new query for CWE-494 "Download of Code Without Integrity Check".
The idea is pretty simple: We flag up any
outfileargument from a web request unless we can taint-tracking it to an argument ofGet-FileHash.We could check that the hash is actually compared with something, but it's probably not worth it.