feat: add page-aware masking for storage key flows#73
Merged
jamesmontemagno merged 7 commits intomainfrom Mar 26, 2026
Merged
Conversation
Add a first page-specific masking rule for Azure Storage access key and SAS pages, reuse the existing secrets toggle, and trigger targeted rescans after trusted interactions so reveal flows get re-masked. Also add focused tests for page rule activation helpers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Protect original title backups during page-rule masking, keep globally matched titles masked during page-rule unmask, and tighten context label matching to avoid substring false positives. Also add focused coverage for page-rule label matching. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Broaden the Azure Storage page rule so long value elements near show/copy controls are treated as sensitive on access key and SAS pages, covering reveal-on-click flows that do not preserve direct label associations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Broaden Azure Storage page-rule discovery so key fields can be matched through nested labels, nearby show/copy actions in ancestor containers, and longer async reveal windows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Generalize the context-aware page-rule runner so multiple rules can reuse the same matching pattern, extend the Azure Storage rule for SAS generate flows, and add an Azure AI Studio key rule for issue #42. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 26, 2026
feat: extend page-rule masking to AI Studio and SAS flows
timheuer
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secretstoggle and run page-aware masking after regex scans, mutation rescans, and trusted interactionsValidation
node --check background.jsnode --check cloak.jsnode --check common.jsnode --check popup.jsnode --test tests/ipaddresses.test.mjs tests/pageSpecificRules.test.mjsShowkey reveal flowsNotes
+62 / -3, 3 files, 1 commit) on top of the original PR branch.Closes #20.
Closes #42.
Refs #45.