Skip to content

Re-enable disabled CLI test (#14321) #15568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesNK merged 3 commits into from
Mar 26, 2026
Merged

Re-enable disabled CLI test (#14321) #15568

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b43da8
Re-enable disabled CLI tests
JamesNK Mar 25, 2026
eb96145
Revert: keep Banner_NotDisplayedWithNoLogoFlag disabled
JamesNK Mar 25, 2026
1602a98
Update tests/Aspire.Cli.Tests/Commands/RunCommandTests.cs
JamesNK Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/Aspire.Cli.EndToEnd.Tests/BannerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ await auto.WaitUntilAsync(
}

[Fact]
[ActiveIssue("https://github.com/microsoft/aspire/issues/14307")]
public async Task Banner_NotDisplayedWithNoLogoFlag()
{
Comment on lines 90 to 93
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-enabling this test will likely reintroduce the original timeout: the test body waits for help output to contain the literal text "Commands:", but the root command help is generated by GroupedHelpWriter (group headings like "App commands:", "Options:", etc.) and does not output a "Commands:" header. Consider updating the wait condition to look for stable text that is actually emitted (e.g., "Usage:" / group headings from HelpGroupStrings, or waiting for the success prompt and then asserting the banner text is absent).

Copilot uses AI. Check for mistakes.
var repoRoot = CliE2ETestHelpers.GetRepoRoot();
Expand Down
1 change: 0 additions & 1 deletion tests/Aspire.Cli.Tests/Commands/RunCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,6 @@ public async Task AppHostHelper_BuildAppHostAsync_IncludesRelativePathInStatusMe
}

[Fact]
[ActiveIssue("https://github.com/microsoft/aspire/issues/14321")]
public async Task RunCommand_SkipsBuild_WhenExtensionDevKitCapabilityIsAvailable()
Comment thread
JamesNK marked this conversation as resolved.
Outdated
{
var buildCalled = false;
Expand Down
Loading