Announce completed CLI session removals to the opt-in catalog inbox - #369
Open
Brian Krabach (bkrabach) wants to merge 1 commit into
Open
Brian Krabach (bkrabach) wants to merge 1 commit into
Brian Krabach (bkrabach) wants to merge 1 commit into
Conversation
Brian Krabach (bkrabach)
marked this pull request as ready for review
October 4, 2026 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful CLI session deletion removes its native directory without announcing its former location. A catalog scanning existing directories cannot observe that absent path, so a previously indexed session can remain in ordinary discovery.
This additive change captures an existing exact canonical same-user source path before removal, then publishes the existing opt-in location-only notice after successful native delete/checkpoint completion or cleanup. Bounded parent identities and repeated physical absence reject aliases, replaced parents, and recreated paths. Failed, busy, skipped, or unconfirmed removals do not announce; notice failures never veto native success. The catalog independently observes absence and retains the read-only mapping without changing nativeDeleted or productHidden.
Depends on #368 (save/rename producer), which remains externally REVIEW_REQUIRED. This PR is stacked on that unchanged branch; neither PR establishes live CLI adoption. Whole-home/project reset and failed-save rollback are explicitly separate from these per-session removal notices.
Validation: 65 source and 65 independently extracted wheel checks pass, including real Click shared/ordinary delete, cleanup, busy/checkpoint/refusal cases, source/parent replacement, private inbox gates, and zero opt-out notice I/O. The actual installed CLI baseline leaves stale rows after delete, CLI cleanup, and direct store cleanup; the candidate emits one notice per case and one bounded catalog4744 consumer pass excludes the missing row. All 103 Python runtime files match source/wheel/extraction; unrelated native bytes stay identical, with zero catalog history-body opens or agents. No global scan/rebuild, model activation, live deletion, or Catalog schema change.