feat: make slash completion prefix-first with advisory arguments - #336
Merged
Merged
Conversation
Make slash completion prefix-first while keeping known argument suggestions advisory. Preserve explicit selection semantics, popup settings, and CPR-safe ambiguity guidance with regression coverage and documentation. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Use both prompt-toolkit parser and key-binding timeout controls in Escape timing tests so the test-only follow-up is portable across platforms. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make interactive slash completion prefix-first while keeping argument suggestions optional.
The existing
ui.slash_popup.enabledsetting still defaults to true. Setting it to false disables automatic command and argument menus, not manual Tab completion or advisory argument submission. Command validation, completion metadata, and snapshot-only keypress callbacks are unchanged.Verification
uv run --with truststore pytest -q— 2,183 passed, 1 skipped, 13 deselected, 1 xfailed.uv run --with truststore pytest -q -m integration— 13 passed.uv run --with truststore pytest -q tests/test_interactive_slash_completion.py tests/test_interactive_chat_tty_teardown.py— 74 passed.The corrected live report retains an overall PARTIAL label because two text-readiness probes timed out. Fresh screenshots immediately afterward confirmed the live session title and prompt before the tested flows; all four corrected keyboard cases passed. The initial failure report is preserved separately. Exact trailing-space counts are covered by real PromptSession pipe tests rather than whitespace-trimming screen captures.
Scope and limitations