Add to read the configure - #47
Open
lindexi (lindexi) wants to merge 4 commits into
Open
Conversation
Alex Eyler (AlexEyler)
suggested changes
Feb 6, 2018
Alex Eyler (AlexEyler)
left a comment
Alex Eyler (AlexEyler)
left a comment
Contributor
There was a problem hiding this comment.
This is a pretty common pattern that we see extension authors use to grab the dialog page for options. I'd just recommend a couple small changes to make it a little clearer for other users.
|
|
Author
|
Mads Kristensen (@madskristensen) Why close it? |
Contributor
|
Perhaps a mistake. Reopening |
Author
|
Alex Eyler (@AlexEyler) Can merge? |
|
Any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dever want to get the configure but the OptionsPageCS not say how to get the configure.
Add the
static OptionsPagePackageCS EnsurceOptionsPagePackageCsget the package that can get the configure.