Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Values whose entries all trim to empty can be incorrectly treated as input filenames.
Review effort: Balanced
Findings: 1
What changed in this PR
Addresses #64618 by trimming whitespace from comma-separated string-list CLI values, matching enum-list parsing.
Changes:
- Trim each string-list entry before validation.
- Add regression coverage for four compiler options.
| File | Description |
|---|---|
| tsc/internal/tsoptions/commandlineparser.go | Trim whitespace from string-list entries. |
| tsc/internal/tsoptions/commandlineparser_test.go | Test trimming and resolved option values. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| case "string": | ||
| elements := core.MapFiltered(values, func(v string) (any, bool) { | ||
| val, err := validateJsonOptionValue(opt.Elements(), v, nil, nil) | ||
| val, err := validateJsonOptionValue(opt.Elements(), strings.TrimFunc(v, stringutil.IsWhiteSpaceLike), nil, nil) |
Contributor
Author
There was a problem hiding this comment.
This is a separate issue. --lib also suffers from this:
> npx tsc --showConfig --lib ", ," index.ts
{
"compilerOptions": {},
"files": [
"./, ,",
"./index.ts"
]
}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64618
Now it matches
TypeScript/tsc/internal/tsoptions/commandlineparser.go
Line 381 in 0681ef7