Skip to content

fix: improve error message for JSX in non-module files (Issue #64438) #64616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Om Dandagvhal (OMD-123) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve error message for JSX in non-module files (Issue #64438) #64616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tsc/internal/checker/jsx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1452,6 +1452,11 @@ func (c *Checker) getJsxNamespaceContainerForImplicitImport(location *ast.Node)
if links.jsxImplicitImportContainer != nil {
return core.IfElse(links.jsxImplicitImportContainer == c.unknownSymbol, nil, links.jsxImplicitImportContainer)
}
// If the file is not an external module (no imports/exports), it cannot import the JSX runtime.
// Return nil to avoid the confusing "module path ... could not be found" error (Issue #64438).
if file.ExternalModuleIndicator == nil {
Comment on lines +1455 to +1457
return nil
}
canonicalErrorTag := links.firstJSXTagInFile
if canonicalErrorTag == nil {
var visit ast.Visitor
Expand Down