Skip to content

Update localization files - #64608

Merged
Jake Bailey (jakebailey) merged 7 commits into
mainfrom
localization-update
Oct 3, 2026
Merged

Jake Bailey (jakebailey) merged 7 commits into
mainfrom
localization-update

Conversation

@typescript-automation

Copy link
Copy Markdown
Contributor

Updates localization handbacks and their generated runtime artifacts.

Copilot AI balanced review requested due to automatic review settings October 2, 2026 21:06
@typescript-automation typescript-automation Bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 2, 2026

@jakebailey Jake Bailey (jakebailey) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No merge yet, need to have this DCE

@github-project-automation github-project-automation Bot moved this from Not started to Waiting on author in PR Backlog Oct 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

Updates the localization pipeline configuration to use an assigned OneLoc package ID and tweaks Go module caching behavior.

Changes:

  • Sets OneLocLclPackageId to the assigned LCL package ID.
  • Adjusts the Go modules cache key inputs by removing go.work.sum.
File Description
tools/​pipelines/​localization-update.yml Updates OneLoc package ID and modifies the cache key for Go module caching.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread tools/pipelines/localization-update.yml
Comment thread tools/pipelines/localization-update.yml Outdated
Automated localization updates should expose translation changes rather
than ordering churn or redundant English fallbacks. Obsolete entries
should not remain in the checked-in handbacks after regeneration.
The localization job starts from a shallow checkout and only needs the
existing automation branch's tip and tree. Fetching its full history can
stall PR updates without any visible progress.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The activated OneLoc pipeline needs validation against real package output and metadata before approval.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
Resolved since last review (2)

"A_get_accessor_must_be_at_least_as_accessible_as_the_setter_2808": "Um acessador get precisa ser pelo menos tão acessível quanto o setter",
"A_get_accessor_must_return_a_value_2378": "Um acessador 'get' deve retornar um valor.",
"A_label_is_not_allowed_here_1344": "Um rótulo não é permitido aqui.",
"A_label_is_not_allowed_here_1344": "A label is not allowed here.",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have a list of these and need to report them.

@jakebailey
Jake Bailey (jakebailey) added this pull request to the merge queue Oct 3, 2026
Merged via the queue into main with commit cb72b2e Oct 3, 2026
30 checks passed
@jakebailey
Jake Bailey (jakebailey) deleted the localization-update branch October 3, 2026 03:47
@github-project-automation github-project-automation Bot moved this from Needs merge to Done in PR Backlog Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants