fix(30408): improve error message for labels used before definition#63302
Closed
wdskuki wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix(30408): improve error message for labels used before definition#63302wdskuki wants to merge 1 commit intomicrosoft:mainfrom
wdskuki wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The error message 'Jump target cannot cross function boundary' was confusing because it didn't indicate which label was causing the issue. This change adds the label name to the error message when available. Before: 'Jump target cannot cross function boundary.' After: 'Jump target 'loopend' cannot cross function boundary.' Fixes microsoft#30408
Member
|
Sorry, but we are not accepting PRs of this kind at this time. https://github.com/microsoft/TypeScript#:~:text=NOTE%3A%20Code%20changes%20in%20this%20repo%20are%20now%20limited%20to%20a%20small%20category%20of%20fixes%3A With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
Member
|
(Also, this seems to be an LLM generated PR, and clearly did not have any tests run.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The error message 'Jump target cannot cross function boundary' was confusing because it didn't indicate which label was causing the issue. This change adds the label name to the error message when available.
Changes
Before
After
Example
Fixes #30408