Fix: Polly retry policy not retrying CTS-triggered timeouts in PackageUploader#127
Open
elahmed-microsoft wants to merge 1 commit into
Open
Fix: Polly retry policy not retrying CTS-triggered timeouts in PackageUploader#127elahmed-microsoft wants to merge 1 commit into
elahmed-microsoft wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts request cancellation behavior so Polly can retry timeouts by avoiding per-request CancellationTokenSource timeouts and relying on transport-layer timeouts instead.
Changes:
- Removed scoped
CancellationTokenSourcetimeout fromInitializeAssetAsync. - Passed the caller-provided cancellation token directly into
HttpClient.SendAsync.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
161
to
+163
| using var req = CreateJsonRequest(HttpMethod.Post, $"{assetId}/initialize", deltaUpload, properties, XfusJsonSerializerContext.Default.UploadProperties); | ||
| using var cts = new CancellationTokenSource(_uploadConfig.HttpTimeoutMs); | ||
|
|
||
| var response = await _httpClient.SendAsync(req, cts.Token).ConfigureAwait(false); | ||
| var response = await _httpClient.SendAsync(req, ct).ConfigureAwait(false); |
Comment on lines
161
to
+163
| using var req = CreateJsonRequest(HttpMethod.Post, $"{assetId}/initialize", deltaUpload, properties, XfusJsonSerializerContext.Default.UploadProperties); | ||
| using var cts = new CancellationTokenSource(_uploadConfig.HttpTimeoutMs); | ||
|
|
||
| var response = await _httpClient.SendAsync(req, cts.Token).ConfigureAwait(false); | ||
| var response = await _httpClient.SendAsync(req, ct).ConfigureAwait(false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now instead uses the caller's cancellation token directly instead of a scoped CTS. A scoped CTS causes Polly to see the token as intentionally canceled on timeout, which prevents retries. HttpClient.Timeout (set to HttpUploadTimeoutMs) handles per-request timeouts at the transport layer, allowing Polly to retry normally.