Add support for AzureRoleEligibilityScheduleSettings#6977
Open
mpoulson wants to merge 3 commits intomicrosoft:Devfrom
Open
Add support for AzureRoleEligibilityScheduleSettings#6977mpoulson wants to merge 3 commits intomicrosoft:Devfrom
mpoulson wants to merge 3 commits intomicrosoft:Devfrom
Conversation
Collaborator
FabienTschanz
left a comment
There was a problem hiding this comment.
The Ensure parameter is missing. Either it is added or if the resource only exists once in this combination, then IsSingleInstance must be added. At least one of those two properties must be present.
...ces/MSFT_AzureRoleEligibilityScheduleSettings/MSFT_AzureRoleEligibilityScheduleSettings.psm1
Outdated
Show resolved
Hide resolved
...ces/MSFT_AzureRoleEligibilityScheduleSettings/MSFT_AzureRoleEligibilityScheduleSettings.psm1
Outdated
Show resolved
Hide resolved
...ces/MSFT_AzureRoleEligibilityScheduleSettings/MSFT_AzureRoleEligibilityScheduleSettings.psm1
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Should be ready to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Initial release to add AzureRoleEligibilityScheduleSettings to align with AADRoleSetting. Allow setting the Azure Role PIM Assignment and Eligibility settings for each role at the various scopes.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).