Skip to content

Add support for AzureRoleEligibilityScheduleSettings#6977

Open
mpoulson wants to merge 3 commits intomicrosoft:Devfrom
mpoulson:mpoulson/6974-pr
Open

Add support for AzureRoleEligibilityScheduleSettings#6977
mpoulson wants to merge 3 commits intomicrosoft:Devfrom
mpoulson:mpoulson/6974-pr

Conversation

@mpoulson
Copy link
Contributor

Pull Request (PR) description

Initial release to add AzureRoleEligibilityScheduleSettings to align with AADRoleSetting. Allow setting the Azure Role PIM Assignment and Eligibility settings for each role at the various scopes.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

Copy link
Collaborator

@FabienTschanz FabienTschanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ensure parameter is missing. Either it is added or if the resource only exists once in this combination, then IsSingleInstance must be added. At least one of those two properties must be present.

@mpoulson
Copy link
Contributor Author

Should be ready to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AzureRoleEligibilityScheduleSettings: New Resource Proposal

3 participants