Fix TeamsTemplatesPolicy error handling to prevent false drift (Fixes…

[Shiva210Jyoti]

Fixes #6899

Ensures TeamsTemplatesPolicy cmdlet failures are terminating by replacing SilentlyContinue and implicit non-terminating errors with -ErrorAction Stop for Get-CsTeamsTemplatePermissionPolicy and Get-CsTeamTemplateList.

This prevents partial state evaluation when Teams APIs return malformed responses, eliminating false-positive drift on HiddenTemplates.

Changes are minimal and localized to MSFT_TeamsTemplatesPolicy.psm1.

[ricmestre]

What if I want to create a policy that doesn't exist yet? With your diff it will throw an error and the resource won't be created.

Did you actually tested this?

[FabienTschanz]

The -ErrorAction Stop on Get-CsTeamTemplateList is correct in my opinion, and also the one in the Export-TargetResource. However, as @ricmestre mentioned, the first instance must not be like that, otherwise it will never work for non-existing instances, which is a very valid scenario. This cannot be fixed on an individual resource level but must rather be regarded as a matter affecting all resources and thus treated as such using better error handling.

[ricmestre]

Correct, with that changed the rest of the diff is fine by me

[SNikalaichyk]

Agree with @ricmestre.

It is important to handle the actual exception thrown by Get-CsTeamsTemplatePermissionPolicy to not re-throw the Object not found one and to return valid drift. The actual exception type and message needs to be confirmed first.

[NikCharlebois]

@Shiva210Jyoti can you update your PR accordingly? Thanks

[Shiva210Jyoti]

@microsoft-github-policy-service agree

[Shiva210Jyoti]

Thanks for the feedback everyone.

Updated the implementation so that only the first Get-CsTeamsTemplatePermissionPolicy call is wrapped in targeted try/catch logic. It now returns $nullReturn for NotFound scenarios while keeping other failures terminating, which allows creation of new policies while still preventing partial-state evaluation.

Confirmed behavior:
• Non-existing policy → returns Absent state (no error)
• API failure / malformed response → terminating error

Other cmdlet calls retain -ErrorAction Stop as suggested.

Ready for re-review.

[FabienTschanz]

@Shiva210Jyoti Please add an entry to the changelog. Thank you.