Fix XBEGIN C7 F8 decoding#376
Open
RatinCN wants to merge 1 commit into
Open
Conversation
Only the exact C7 F8 encoding is XBEGIN. The previous C7 /7 check also treated other ModR/M forms as XBEGIN and copied them as rel16/32 targets instead of invalid or legacy C7 forms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addendum to #374, already fixed in my SlimDetours in commit 65b60a7.
Only the exact C7 F8 encoding is
XBEGIN. The previous C7 /7 check also treated other ModR/M forms asXBEGINand copied them as rel16/32 targets instead of invalid or legacy C7 forms.See also the latest Intel® 64 and IA-32 Architectures Software Developer's Manual Combined Volumes 2A, 2B, 2C, and 2D: Instruction Set Reference, A- Z:
