Fix snapshot download since parameter to use closed/inclusive semantics#7775
Merged
Fix snapshot download since parameter to use closed/inclusive semantics#7775
since parameter to use closed/inclusive semantics#7775Conversation
…cs (#7742) Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/27aad86e-2bff-4d61-95e8-a5e3d3c987b5
Copilot created this pull request from a session on behalf of
achamayou
March 26, 2026 11:28
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the since query parameter semantics on GET /node/snapshot with GET /node/ledger_chunk by making snapshot filtering closed/inclusive, and removes the related off-by-one workaround in backup snapshot fetching.
Changes:
- Make snapshot discovery treat
since=Nas inclusive (return snapshots with index>= N). - Remove the
- 1workaround when scheduling backup snapshot fetches based on snapshot evidence. - Update E2E expectations and document the behavior change in the changelog.
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/snapshots/filenames.h |
Adjusts minimum snapshot index filtering to be inclusive (< instead of <=). |
src/node/node_state.h |
Removes the off-by-one adjustment when scheduling BackupSnapshotFetch tasks. |
tests/e2e_operations.py |
Updates snapshot endpoint since parameter expectations to match inclusive behavior. |
CHANGELOG.md |
Documents the updated since semantics for GET /node/snapshot. |
src/node/quote_endorsements_client.h |
Contains an unrelated constructor formatting-only change. |
src/js/extensions/ccf/kv.cpp |
Contains an unrelated constructor formatting-only change. |
src/js/extensions/ccf/historical.cpp |
Contains an unrelated constructor formatting-only change. |
src/endpoints/authentication/cose_auth.cpp |
Contains an unrelated constructor formatting-only change. |
Member
|
@copilot fix the formatting! |
… braces Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/f839ee9d-aece-42a4-b605-bef90d7df677
Contributor
Author
eddyashton
reviewed
Mar 26, 2026
Contributor
Author
|
@eddyashton I've opened a new pull request, #7777, to work on those changes. Once the pull request is ready, I'll request review from you. |
eddyashton
reviewed
Mar 26, 2026
Co-authored-by: Eddy Ashton <ashton.eddy@gmail.com>
Co-authored-by: Eddy Ashton <ashton.eddy@gmail.com>
eddyashton
reviewed
Mar 26, 2026
Co-authored-by: eddyashton <6000239+eddyashton@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/a800a453-3652-4c35-90e1-2954fd43e6fb
eddyashton
approved these changes
Mar 26, 2026
eddyashton
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sincesemantics, while ledger chunk uses closed/inclusive; align snapshot to closed/inclusivesrc/snapshots/filenames.h: filter conditionidx <= minimum_idx→idx < minimum_idx- 1 /* YIKES */hack insrc/node/node_state.htests/e2e_operations.py(since=snapshot_indexnow returns snapshot)CHANGELOG.mdcose_auth.cpp,historical.cpp,kv.cpp,quote_endorsements_client.h)📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.