ci: write the npm token at release time - #905
Merged
Merged
Conversation
Drop ${NPM_TOKEN} from the project .npmrc so pnpm stops warning.
Write it to both pnpm and npm user config so lerna can publish
without dirtying the tree.
lerna publishes via npm; pnpm config set is unused.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe release workflow now sets the npm registry authentication token with ChangesRelease authentication
Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Coverage is 79.564% — ci/release-token-just-in-time into master. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${NPM_TOKEN}from the committed.npmrcso pnpm 11 stops warning on every install.pnpm config set+npm config set). lerna publishes via npm; pnpm's store alone is not enough. Neither write touches the repo, so lerna staysEUNCOMMIT-clean.Test plan
E404/E401gone)Note
Low Risk
CI-only credential wiring and .npmrc cleanup; no runtime or application logic changes.
Overview
Removes the committed
//registry.npmjs.org/:_authToken=${NPM_TOKEN}line from.npmrcso routinepnpm installon pnpm 11 no longer logs ignored project-level auth warnings.The release job in
.github/workflows/main.ymlnow sets the registry token withnpm config set(user config) instead ofpnpm config set, solerna publishcan authenticate without touching the repo and keeping the working tree clean for release.Reviewed by Cursor Bugbot for commit 680b2d5. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit