Feat/allow int candidates#370
Draft
graceg571 wants to merge 2 commits into
Draft
Conversation
graceg571
force-pushed
the
feat/allow-int-candidates
branch
from
c7d7185 to
ac74d1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #359 (partial - RankBallot only)
Allows integer candidates as input to
RankBallotrankingargument, in addition to the existing string support.Implementation
RankingLiketype alias to accept integer and string candidatesRankBallot.__init__to preserveRankBallot.rankingstorage astuple[frozenset(str)].Reconsidering having mixed candidate inputs. May be better to enforce all int or str candidates even if they are stored as strings within the
RankBallotobject because 1 == "1" is not true and would create one candidate when the user could have intended two.ScoreBallot is not yet included. The blocker is
ScoreBallot.scoresis stored as a dict where the key type is invariant. We would not mix string and integer candidate names within the sameScoreBallot, andscoreswould be stored as strings.Requires #368 first