This repository was archived by the owner on Apr 28, 2023. It is now read-only.
Minor musette updates - #210
Open
davidseguin wants to merge 5 commits into
Open
davidseguin wants to merge 5 commits into
davidseguin wants to merge 5 commits into
Conversation
davidseguin
requested review from
JosephCurley and
stephenhmarsh
as code owners
September 28, 2022 15:23
| } | ||
| } | ||
|
|
||
| .la-musette--rtl { |
Collaborator
There was a problem hiding this comment.
would prefer if all new code has snapshot coverage... that's kind of the point! :)
stephenhmarsh
left a comment
stephenhmarsh
left a comment
Collaborator
There was a problem hiding this comment.
looks good but just have the 1 question about rtl vs row-reverse
| } | ||
|
|
||
| .la-musette--rtl { | ||
| flex-direction: row-reverse; |
Collaborator
There was a problem hiding this comment.
Does direction: rtl; work here? If the musette gets embedded in some other component that's already rtl we probably don't want to still row-reverse do we ?
| - ### [Storybook Development](#Storybook-Development) | ||
| - ### [Webpack Build for Release And Production](#[Webpack-Build-for-Release-And-Production) | ||
| - ### [Browsers We Support](#Browsers-We-Support) | ||
| - [What is Marble?](#What-is-Marble) |
Collaborator
There was a problem hiding this comment.
thank you for the README improvements! i added a couple more
JosephCurley
approved these changes
Dec 13, 2022
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To work with new Marble v1.2.3 layout and fix a few small things in README