Repository navigation
Migrated NewsListViewModel to shared module - #747
Merged
Merged
Conversation
nirvan73
force-pushed
the
migrate/newList-viewmodel
branch
from
June 10, 2026 10:59
3bc8677 to
4a5f02c
Compare
07jasjeet
approved these changes
Jun 13, 2026
nirvan73
force-pushed
the
migrate/newList-viewmodel
branch
from
June 13, 2026 12:20
4a5f02c to
237dddf
Compare
07jasjeet
approved these changes
Jun 18, 2026
- Moved parseResponse utility blocks to the shared module - Relocated ResponseError, Resource, and ApiError models - Updated repository layers and other connected files to use shared types
… them in KoinModules.kt
nirvan73
force-pushed
the
migrate/newList-viewmodel
branch
from
June 18, 2026 17:44
237dddf to
71f76ad
Compare
07jasjeet
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base PR: #745
Rebased with the latest upstream/cmp branch, and cherry-picked few commits from above mentioned base PR.
This PR fixes #707 migrates the
NewsListViewModelfrom nativeandroidAppmodule tosharedmodule.Key Changes:-
NewsListViewModelto shared/commonMain/viewmodel/ using kmp lifecycle dependencies.sharedViewModelModule, service undersharedNetworkServiceModuleand repos undersharedRepositoryModule.sharedModulesto the coreKoinModulesunderandroidAppmodule.