Stop telemetry queries from generating telemetry - #4769
Open
johnwhumphreys wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@johnwhumphreys has exported this pull request. If you are a Meta employee, you can view the originating Diff in D118294147. |
Summary: Telemetry queries call `TelemetryActor.scan`, so they currently write into the tables they are reading. A real job on master showed each table scan added 1 `messages` row, 3 `message_status_events` rows, 2 `spans` rows, 4 query/scanner `events` rows, and 3 `mailbox.posts`. Four repeated queries returned scan message counts `[0, 1, 2, 3]` and mailbox-post totals `[83, 86, 89, 92]`. Mark `TelemetryActor` endpoints as non-recording. The same class flag disables caller-side endpoint instrumentation and receiver-side actor instrumentation, while `SUPPRESS_TELEMETRY` follows requests and replies. Suppressed envelopes also skip mailbox metrics and tracing. Exclude `monarch_distributed_telemetry` events from all tracing sinks. Application telemetry remains enabled. Remove the obsolete dashboard caveat. The Admin `/v1/query` proxy uses the fixed path. `/v1/tree` still generates topology traffic: 3 calls changed `Resolve` messages from 328 to 447. Track that separately in T286999638. Differential Revision: D118294147
johnwhumphreys
force-pushed
the
export-D118294147
branch
from
September 1, 2026 19:49
3e73e32 to
e72d7e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Telemetry queries call
TelemetryActor.scan, so they currently write into the tables they are reading. A real job on master showed each table scan added 1messagesrow, 3message_status_eventsrows, 2spansrows, 4 query/scannereventsrows, and 3mailbox.posts. Four repeated queries returned scan message counts[0, 1, 2, 3]and mailbox-post totals[83, 86, 89, 92].Mark
TelemetryActorendpoints as non-recording. The same class flag disables caller-side endpoint instrumentation and receiver-side actor instrumentation, whileSUPPRESS_TELEMETRYfollows requests and replies. Suppressed envelopes also skip mailbox metrics and tracing. Excludemonarch_distributed_telemetryevents from all tracing sinks. Application telemetry remains enabled. Remove the obsolete dashboard caveat.The Admin
/v1/queryproxy uses the fixed path./v1/treestill generates topology traffic: 3 calls changedResolvemessages from 328 to 447. Track that separately in T286999638.Differential Revision: D118294147