Remove UA_868 as obsolete#10994
Conversation
|
|
|
|
@sashko, Welcome to Meshtastic!Thanks for opening your first pull request. We really appreciate it. We discuss work as a team in discord, please join us in the #firmware channel. Welcome to the team 😄 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe Ukraine LoRa regulatory table updates the legal reference for ChangesUkraine Region Update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/mesh/RadioInterface.cpp`:
- Around line 187-190: Remove the remaining UA_868 option and direct UA_868
assignments from the region-selection paths in MenuApplet and MenuHandler, or
implement an explicit migration/fallback that converts existing UA_868
configurations to a supported region before initRegion() can return UNSET. Keep
the region picker and configuration handling aligned with the remaining
RadioInterface region table entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 9ce13989-efce-41dd-9e6f-df9015cbd7c0
📒 Files selected for processing (1)
src/mesh/RadioInterface.cpp
|
I kindly and openly request Ukrainian amateur radio operators and Meshtastic users to thoroughly review and discuss this change. |
|
This is a new and interesting development. We'll have a discussion on the best way to retire this region definition. |
@NomDeTom Please, invite me to those discussions if possible. I'll be more than happy to do as much work as I can myself. I'll also try to involve the Ukrainian Meshtastic community in testing. It's |
sashko
force-pushed
the
develop
branch
2 times, most recently
from
a1f8153 to
7b766e6
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/mesh/NodeDB.cpp (1)
627-630: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winShorten the explanatory comment
This four-line comment exceeds the repository’s one- or two-line C++ comment guideline. Keep only the non-obvious rationale, for example:
// Migrate removed UA_868 configs before region validation.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/mesh/NodeDB.cpp` around lines 627 - 630, Shorten the comment describing the UA_868 migration to one concise line, retaining only the rationale that removed UA_868 configurations must be migrated before region validation.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/mesh/NodeDB.cpp`:
- Around line 627-635: Move the UA_868-to-EU_868 migration in NodeDB
initialization to occur before resetRadioConfig() invokes initRegion(), ensuring
myRegion is initialized to EU_868 during the same boot. Keep the existing
migration condition, assignment, and log message unchanged.
---
Nitpick comments:
In `@src/mesh/NodeDB.cpp`:
- Around line 627-630: Shorten the comment describing the UA_868 migration to
one concise line, retaining only the rationale that removed UA_868
configurations must be migrated before region validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: be5f2726-6172-4fd2-8569-47279c55bddc
📒 Files selected for processing (4)
src/graphics/draw/MenuHandler.cppsrc/graphics/niche/InkHUD/Applets/System/Menu/MenuApplet.cppsrc/mesh/NodeDB.cppsrc/mesh/RadioInterface.cpp
💤 Files with no reviewable changes (2)
- src/graphics/draw/MenuHandler.cpp
- src/graphics/niche/InkHUD/Applets/System/Menu/MenuApplet.cpp
🚧 Files skipped from review as they are similar to previous changes (1)
- src/mesh/RadioInterface.cpp
sashko
force-pushed
the
develop
branch
3 times, most recently
from
4973926 to
ce7f287
Compare
Decree of the Cabinet of Ministers of Ukraine dated February 25, 2026,* No. 262, on amendments to Section 2 of the Plan for the Allocation and Use of the Radio Frequency Spectrum in Ukraine, has harmonised Ukrainian regulations on the 868 MHz spectrum with the EU's, thereby making UA_868 legally obsolete. * https://zakon.rada.gov.ua/laws/show/262-2026-п
4 participants
Decree of the Cabinet of Ministers of Ukraine dated February 25, 2026,* No. 262, on amendments to Section 2 of the Plan for the Allocation and Use of the Radio Frequency Spectrum in Ukraine, has harmonised Ukrainian regulations on the 868 MHz spectrum with the EU's, thereby making UA_868 legally obsolete.
🤝 Attestations
Summary by CodeRabbit
Summary by CodeRabbit
Summary
New Features
Bug Fixes
Chores