Issuefix - #469
Issuefix#469
Conversation
|
@Ameer-5-5 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
MergeKeeper review Scope: in scope for linked issue Implemented robust error handling, Pino logging, and unit tests for Stellar Horizon network failures as required by issue #344. Reviewed commit: |
|
MergeKeeper merge status Status: blocked Reason: One or more required CI checks failed. Failing checks:
Next steps:
|
|
Please Resolve Conflict @Ameer-5-5 |
|
resolve conflicts so i can merge |
|
Conflict resolved |
main has failed CI since mergepay#468, which committed syntactically broken src/plugins/openapi.ts (duplicate fastify-plugin import, missing closing `});`), src/routes/expenses.ts and src/routes/groups.ts (orphaned schema fragments, truncated route bodies). Restore all three to their last green state (82025f1, "Revert ... (mergepay#493)") — the only commit that touched them since. Also fix two type errors introduced by the just-merged PRs: - error-handler.ts (mergepay#469): cast err through `unknown` before `Record<string, unknown>`. - horizon-retry.ts (mergepay#470): widen `extractResponse`'s return type with an optional top-level `result_codes`. npm run build + npm test both green (1799 tests). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 participants
CLOSES #344
What does this PR do?
Checklist
npm run buildpassesnpm testpasses (offline — DB/network mocked)mergepay-webRelated issues