Conversation
[Feat/#353] 취향 장르 선택 UI 수정
[Feat/#351] 회원가입 유도 A/B 테스트 제거 및 관심 콘서트 툴팁 추가
Co-authored-by: Copilot <copilot@github.com>
[Feat/#356] 콘서트 상세 페이지 UI
…feat/#357/search-page
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…fix/#370/v6-1st-QA Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
[Fix/#370] 6차 스프린트 1차 QA 반영
…-exposure [Feat/#374] 관심 콘서트 토스트 노출 관련 api
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
[Fix/#376] 6차 스프린트 2차 QA
[Fix/#378] 6차 스프린트 2차 QA 반영
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
[Fix/#380] 인스타그램 이미지 깨지는 문제 해결
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces significant updates to the interest concert feature, including a new interest concert list page, carousel components, and enhanced filtering capabilities. It also updates the API version to v6 and refactors several components to improve state management and user interaction. My feedback focuses on improving toast notification visibility by increasing the autoClose duration and suggesting a refactor to pass concert objects directly to the interest concert button instead of parsing strings.
| type SetInterestConcertButtonProps = { | ||
| selectedConcertState: StateWithSetter<string | null>; | ||
| group?: "A" | "B" | "C"; | ||
| selectedConcertsState: StateWithSetter<string | null>; | ||
| isFirst?: boolean; | ||
| disabled?: boolean; | ||
| }; |
There was a problem hiding this comment.
selectedConcertsState prop이 string | null을 다루도록 설계되어 있어, 상위 컴포넌트에서 SelectedConcert[] 배열을 문자열로 변환하고 이 컴포넌트에서 다시 파싱하는 과정이 있습니다. 이는 복잡성을 높이고 잠재적인 오류를 유발할 수 있습니다. selectedConcerts: SelectedConcert[] prop을 직접 받아 처리하도록 리팩터링하는 것을 권장합니다.
2 participants
6차 스프린트 배포~