[Fix/#380] 인스타그램 이미지 깨지는 문제 해결#381
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Fixes broken Instagram images by routing them through the image proxy in the concert detail page and adding onError fallbacks to display an empty-state image when loading fails. Also introduces per-image loading/error tracking with a skeleton placeholder in the selectable infinite concert list.
Changes:
- Apply
getImageSrc(instagram proxy) to the concert detail hero image inDetailInfo. - Add
onErrorfallbacks that swap in an empty-card icon for several concert image components. - Add load/error state tracking with skeleton + fade-in in
SelectableInfiniteConcertList.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/entities/concert/ui/DetailInfo.tsx | Route detail image URL through getImageSrc so Instagram images use the proxy. |
| src/entities/concert/ui/MdCard.tsx | Fallback to EmptyConcertCardIcon on image load error. |
| src/entities/concert/ui/MdSlideCard.tsx | Fallback to EmptyConcertCardIcon on image load error. |
| src/entities/concert/ui/SectionConcertSlideCard.tsx | Fallback to EmptyConcertCardIcon on image load error. |
| src/features/interest/ui/InterestConcertCarouselSlide.tsx | Fallback to ConcertPosterEmptyIcon on image load error. |
| src/features/interest/ui/SelectableInfiniteConcertList.tsx | Track per-concert loading/error state with skeleton placeholder and empty card fallback; adds unused useNavigate import. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive image error handling across several concert UI components by adding onError handlers and fallback icons. It also implements a loading state with a skeleton animation for the SelectableInfiniteConcertList component. Feedback highlights that the current state management for image loading in the infinite list may not correctly handle new items appended during scrolling, suggesting a shift from tracking 'loading' state to tracking 'loaded' state for better reliability.
|
|
📌 이슈 번호
📌 PR 유형
📌 PR 내용