Skip to content

[Fix/#378] 6차 스프린트 2차 QA 반영#379

Merged
ah-o-ng12 merged 3 commits into
developfrom
fix/#378/v6-2nd-QA
May 10, 2026
Merged

[Fix/#378] 6차 스프린트 2차 QA 반영#379
ah-o-ng12 merged 3 commits into
developfrom
fix/#378/v6-2nd-QA

Conversation

@cjw020607

@cjw020607 cjw020607 commented May 10, 2026

Copy link
Copy Markdown
Contributor

📌 이슈 번호

📌 PR 유형

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

📌 PR 내용

  1. 인스타그램 이미지 깨지는 문제 해결
  2. 모바일일 때 장르 탭 및 관심 콘서트 선택 칩 화살표 제거

📌 참고

  • 인스타그램 이미지는 서버 코드 반영 후 확인 가능

cjw020607 and others added 2 commits May 10, 2026 23:57
Co-authored-by: Copilot <copilot@github.com>
@cjw020607 cjw020607 self-assigned this May 10, 2026
Copilot AI review requested due to automatic review settings May 10, 2026 15:07
@cjw020607 cjw020607 added the 🐛 Bug 버그 수정 label May 10, 2026
@cjw020607 cjw020607 linked an issue May 10, 2026 that may be closed by this pull request
2 tasks
@vercel

vercel Bot commented May 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
livith-web Ready Ready Preview, Comment May 10, 2026 3:17pm

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an image proxy utility, getImageSrc, to handle Instagram images across multiple concert-related components and adds touch device detection to GenreTabs and SelectedSection to refine the mobile UI. Review feedback suggests centralizing the isTouchDevice logic into a shared utility for better maintainability and ensuring consistent event handling. Additionally, it is recommended to use the URL API for more robust domain validation in the image proxy utility to avoid potential regex matching issues.

Comment thread src/features/interest/ui/SelectedSection.tsx
Comment thread src/shared/utils/getImageSrc.ts
@cjw020607 cjw020607 requested a review from ah-o-ng12 May 10, 2026 15:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ah-o-ng12

Copy link
Copy Markdown
Contributor

20260424_212544.jpg

@ah-o-ng12 ah-o-ng12 merged commit 76ad2f7 into develop May 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 Bug 버그 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] 6차 스프린트 2차 QA 반영

3 participants