Fix broken popover hint example - #396
Open
chrisdavidmills wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While fixing mdn/content#45515 (see mdn/content#45550), I noticed that my popover=hint example was broken: https://mdn.github.io/dom-examples/popover-api/popover-hint/. The auto and hint popovers now all appear in the top-left of the viewport.
This PR fixes the example. For the auto popovers, I replaced the
anchor()/anchor-centerpositioning withposition-areapositioning. For the hint popovers, I kept theanchor()/anchor-centerpositioning, but made sure to include a margin reset and includedposition-anchor: auto;because it seems like this is now needed to opt-in to the association in this case.It now works fine in Chromiums and Fx. In Safari it works, except that the auto popovers move to the bottom of the screen when you are not hovering over a popover control (seems like a bug in Safari to me). This is much better support than it used to be; it used to be broken in both Saf and Fx.
Fixes #396