feat: introduce system domains for event ID routing#5
Merged
Conversation
lete114
commented
May 24, 2026
lete114
commented
Member
- Add SYSTEM_DOMAINS constant object (PREFIX, USER, RESPONSE)
- Add EVENTS constant object (INVOKE_RESPONSE)
- Change event ID from ipc:: to ipc::: with domain fixed at position 1 to prevent namespace injection
- Transport.send/onReceive now use (systemDomain, route) parameters
- #handleReceive dispatches by system domain: RESPONSE -> emit to matching invoke Promise by route (= invoke id) USER -> parse Packet, route to on/handle handlers
- Remove fixed @response channel, response routing via domain isolation
- Clean up old constants (CHANNELS, RESPONSE_ENDPOINT, IPC_NAMESPACE, RESPONSE_EVENT_PREFIX)
- Update tests and snapshots
- Add SYSTEM_DOMAINS constant object (PREFIX, USER, RESPONSE) - Add EVENTS constant object (INVOKE_RESPONSE) - Change event ID from ipc:<ns>:<ch> to ipc:<domain>:<ns>:<route> with domain fixed at position 1 to prevent namespace injection - Transport.send/onReceive now use (systemDomain, route) parameters - #handleReceive dispatches by system domain: RESPONSE -> emit to matching invoke Promise by route (= invoke id) USER -> parse Packet, route to on/handle handlers - Remove fixed @response channel, response routing via domain isolation - Clean up old constants (CHANNELS, RESPONSE_ENDPOINT, IPC_NAMESPACE, RESPONSE_EVENT_PREFIX) - Update tests and snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.