Conversation
reset the ride colors i modified to their orig color (#086CB6) bc i realized i would have to modify their bus png color to match the route color, and i didn't do that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed both the CS route color and the color of its png to be a lighter shade of blue because some users were complaining that it blended in in dark mode.
Refactor
One semi-related issue: Could also change the color of some of The Ride routes with a similar shade of blue (would require changing their corresponding PNGs, which is more work)
Changes made: Backend (Typescript)
Tested on: iOS Simulator (in both dark mode and light mode)
Original:
Modified:
*Note: forgot to follow the commit format for first 2 commits. For commit 9e8b55b, fix(backend): Changed CS color in backend\n Changed CS color in backend from #3559B8 (dark blue) to #0099FF (lighter blue) because some users were complaining that CS looked too dark in dark mode. For commit a5716c5, fix(backend): Modified the bus_CS.png using Photoshop\n Modified the bus_CS.png so that the CS bus color would match the new CS route color.