Concise documentation rewrite and a v4 to v5 migration guide - #964
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #964 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 9209 9209
=========================================
Hits 9209 9209 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What does this PR do?
Documentation-only changes, no code behavior is modified.
Rewording of DOCUMENTATION.rst
The entire document has been reworded to be shorter and easier to read, going from 3828 to 3596 lines without removing any section. The changes replace verbose and redundant phrasing with direct statements, and fix the places where the text did not describe what the code actually does.
New migration guide
A new
sphinx/migrate_v5.rstpage (linked from the index asmigrate-v5) explains how to move from v4 to v5. It recommends upgrading to the latest v4, running withJSONARGPARSE_DEPRECATION_WARNINGS=alland fixing every warning before upgrading. It starts with a summary of the breaking changes that need attention, in particular the ones that give no warning or only warn withall, and then covers, with before/after examples and tables:CLItoauto_cli,return_parserand implicit component discovery.Namespacechanges:parse_as_dict,with_meta/default_metaand the removed utility functions.dump,saveandvalidateparameter renames.PathAPI andenable_path.ActionEnum,ActionOperatorsandActionJsonnetExtVars.set_parsing_settings.LoggerProperty,error_handlerandusage_and_exit_error_handler, and the use ofexit_on_errorinstead.ruyamltoruamelextra rename and the fact that internal module paths can no longer be imported.Packaging
yamlextra, included inall, so that the yaml requirement can be installed explicitly, as the migration guide instructs for v5.devnow includesall, so that a development install has every optional feature available.Before submitting