fix: let the configuration dialog scroll on short screens - #726
Merged
Conversation
It has roughly three times the markup of any other dialog and ran off the bottom of the viewport rather than scrolling.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an accessibility/usability issue in jsbeeb’s UI by making the Emulation Configuration Bootstrap modal scroll internally on short viewports, preventing settings “below the fold” from becoming unreachable.
Changes:
- Add Bootstrap’s
modal-dialog-scrollableclass to the configuration modal’s.modal-dialogso the modal body scrolls within the viewport while header/footer remain pinned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Emulation Configuration dialog is around three times the size of any
other dialog in the app (215 lines of markup against 78 for the next
largest,
help). On a short viewport it ran off the bottom of the screenrather than scrolling, so the settings below the fold were unreachable.
Adds Bootstrap's
modal-dialog-scrollable, which caps the dialog at theviewport height and scrolls the modal body internally. The header and the
Close button in the footer stay pinned.
Scoped to this one dialog deliberately: all twelve modals were measured
and this is the only outlier. If
helpproves tight on a short screen itwants the same one-line change.
Testing
Lint clean, 633 unit tests pass,
npm run buildsucceeds. The visualbehaviour was checked by hand rather than automated: the scrollbar belongs
inside the dialog rather than on the page, and the Close button should stay
visible while scrolling the settings.
🤖 Generated with Claude Code