Skip to content

fix: let the configuration dialog scroll on short screens - #726

Merged
mattgodbolt merged 2 commits into
mainfrom
claude/scrollable-config-dialog
Jul 29, 2026
Merged

fix: let the configuration dialog scroll on short screens#726
mattgodbolt merged 2 commits into
mainfrom
claude/scrollable-config-dialog

Conversation

@mattgodbolt

Copy link
Copy Markdown
Owner

The Emulation Configuration dialog is around three times the size of any
other dialog in the app (215 lines of markup against 78 for the next
largest, help). On a short viewport it ran off the bottom of the screen
rather than scrolling, so the settings below the fold were unreachable.

Adds Bootstrap's modal-dialog-scrollable, which caps the dialog at the
viewport height and scrolls the modal body internally. The header and the
Close button in the footer stay pinned.

Scoped to this one dialog deliberately: all twelve modals were measured
and this is the only outlier. If help proves tight on a short screen it
wants the same one-line change.

Testing

Lint clean, 633 unit tests pass, npm run build succeeds. The visual
behaviour was checked by hand rather than automated: the scrollbar belongs
inside the dialog rather than on the page, and the Close button should stay
visible while scrolling the settings.

🤖 Generated with Claude Code

It has roughly three times the markup of any other dialog and ran off the
bottom of the viewport rather than scrolling.
Copilot AI review requested due to automatic review settings July 29, 2026 12:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an accessibility/usability issue in jsbeeb’s UI by making the Emulation Configuration Bootstrap modal scroll internally on short viewports, preventing settings “below the fold” from becoming unreachable.

Changes:

  • Add Bootstrap’s modal-dialog-scrollable class to the configuration modal’s .modal-dialog so the modal body scrolls within the viewport while header/footer remain pinned.

@mattgodbolt
mattgodbolt merged commit c8ae1d4 into main Jul 29, 2026
5 checks passed
@mattgodbolt
mattgodbolt deleted the claude/scrollable-config-dialog branch July 29, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants