Skip to content

Solution added - #4415

Open
olitm wants to merge 3 commits into
mate-academy:masterfrom
olitm:dev
Open

Solution added#4415
olitm wants to merge 3 commits into
mate-academy:masterfrom
olitm:dev

Conversation

@olitm

@olitm olitm commented Sep 3, 2026

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because two core requirements are not met and will likely cause test failures.

Critical issues to fix:

  • In src/App.jsx: The task requires rendering Sum with just a = 10 (omit b), just b = 5 (omit a), and with no params at all. Currently you pass explicit zeros (<Sum a={10} b={0} />, <Sum a={0} b={5} />, <Sum a={0} b={0} />). This conflicts with the requirement to omit those props. Update to <Sum a={10} />, <Sum b={5} />, and <Sum /> respectively.
  • In src/components/Sum/Sum.jsx: The checklist requires using string interpolation inside tag content [CHECKLIST ITEM #2]. Instead of Sum of {a} and {b} is {sum}, render a single interpolated string, e.g. {Sum of ${a} and ${b} is ${sum}} within the <p> element.

Everything else looks good: the component is a named export, defaults are handled, and the sum is computed correctly. Please make these adjustments and run tests; this should satisfy both the functional and checklist requirements. Keep it up—you're very close!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/App.jsx Outdated
Comment thread src/App.jsx
Comment thread src/components/Sum/Sum.jsx Outdated
Comment thread src/components/Sum/Sum.jsx Outdated

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because a critical checklist requirement is not met. In both src/App.jsx and src/components/Sum/Sum.jsx, the paragraph content uses multiple JSX expressions (e.g., Sum of {a} and {b} is {sum}) instead of a single interpolated string, violating [CHECKLIST ITEM #2]. This can cause automated checks to fail even though functionality appears correct. Please update the

to render a single template string: {Sum of ${a} and ${b} is ${sum}}. Specifically: in src/App.jsx line with the paragraph inside the Sum rendering, and in src/components/Sum/Sum.jsx within the component’s return, replace the separated expressions with one interpolated string. Everything else (named export, defaults for a and b, and required Sum usages) looks good—once this interpolation change is made, the submission should meet all requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/App.jsx
Comment thread src/components/Sum/Sum.jsx Outdated

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved. You correctly implemented a named Sum component with default values for a and b, computed the result, and rendered the required string using interpolation inside a single paragraph. In App.jsx, you included all five required Sum instances and used concise one-line tags for short props, aligning with [CHECKLIST ITEM #1] and [CHECKLIST ITEM #2].

One note for improvement: I couldn’t verify from the code alone whether your PR description replaced the DEMO LINK with your GitHub username or whether tests were run. This is an educational override to help you progress while learning—ensure your PR body includes the correct GitHub Pages URL and run npm test locally or via CI for future submissions. Great work overall—clean, readable, and meeting the functional and style requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants