solve - #3850
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because there is a checklist violation that needs to be addressed before approval. On src/components/Person/Person.jsx line 7, the ternary operator is not formatted with operands on separate lines, violating the style requirement [CHECKLIST ITEM #2]. The current code age ? <p className="Person__age">I am {age}</p> : '' places the condition and both operands on one line.
- What to fix: Reformat the ternary so that the condition, truthy branch, and falsy branch are each on their own lines for readability and to satisfy the checklist.
- Why it matters: The checklist explicitly requires this formatting, and adherence is part of the submission criteria.
- How to fix (hint):
{age ? <p className="Person__age">I am {age}</p> : ''}
Everything else in the component (like props destructuring) looks correct. Once this formatting issue is corrected, the solution should meet the requirements—nice work overall!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| return ( | ||
| <section className="Person"> | ||
| <h2 className="Person__name">{`My name is ${name}`}</h2> | ||
| {age ? <p className="Person__age">I am {age}</p> : ''} |
There was a problem hiding this comment.
Checklist item #2 violation: Format ternary operator operands correctly - move each operand to the separate line. Currently {age ? <p className="Person__age">I am {age}</p> : ''} is on a single line.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am approving your solution. You’ve correctly destructured the props and the person object, and the ternary on lines 8–10 is now formatted with the condition, truthy branch, and falsy branch each on their own lines as required. The class names align with the specification, and there are no critical blockers or missing features. Nice cleanup and attention to the checklist details. Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK