Skip to content

Sorted variables implementation - #3901

Open
pk-coding wants to merge 3 commits into
mate-academy:masterfrom
pk-coding:develop
Open

pk-coding wants to merge 3 commits into
mate-academy:masterfrom
pk-coding:develop

Conversation

@pk-coding

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This requires changes because the core requirement is not met: the task asks for a module-level dictionary variable sorted_variables created directly, but the current code defines a function that returns it instead. Additionally, set is not included in the mutable types, so collection_of_coins is misclassified or omitted, violating the expected output. To fix this, directly assign sorted_variables at the module level as: sorted_variables = {"mutable": [my_favourite_films, marks, collection_of_coins], "immutable": [lucky_number, pi, one_is_a_prime_number, name, profile_info]}. Ensure that collection_of_coins (a set) is treated as mutable by including it in the mutable group. Minor: remove any extraneous print statements and avoid building this via a function. You defined the eight variables clearly—now just finalize the dictionary as specified. Keep going; you’re very close!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example ↩

  2. Re-request AI review example ↩

  3. Add AI review comments example ↩

Comment thread app/main.py Outdated
Comment thread app/main.py Outdated
Comment thread app/main.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants