Skip to content

Create dict sorted_vadriables - #3821

Open
Ihnatyshko-Dmytro wants to merge 3 commits into
mate-academy:masterfrom
Ihnatyshko-Dmytro:develop
Open

Create dict sorted_vadriables#3821
Ihnatyshko-Dmytro wants to merge 3 commits into
mate-academy:masterfrom
Ihnatyshko-Dmytro:develop

Conversation

@Ihnatyshko-Dmytro

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation correctly categorizes all variables, but the task description explicitly states to use "Python's built-in type checking to determine if each variable is mutable or immutable." The current approach appears to hardcode the variable references in the dictionary rather than programmatically checking types. Consider using Python's type() or isinstance() to check each variable's type, then categorize based on those type checks. This would make the code more dynamic and scalable, and would fulfill the stated requirement of using built-in type checking.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread app/main.py

@k5sha k5sha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, keep it up! 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants