Skip to content

Catalog Page - #6440

Open
Dluan97 wants to merge 2 commits into
mate-academy:masterfrom
Dluan97:develop
Open

Dluan97 wants to merge 2 commits into
mate-academy:masterfrom
Dluan97:develop

Conversation

@Dluan97

@Dluan97 Dluan97 commented Sep 8, 2026

Copy link
Copy Markdown
  • DEMO LINK

  • TEST REPORT LINK

  • [x ] All components follow BEM and use SCSS

  • [ x] Repeated sizes and special colors are put to variables

  • [ x] Grid is used for the columns

  • [ x] Cards are shown in 1, 2, 3, or 4 columns based on screen resolution

  • [ x] All changes on :hover are smooth

  • [ x] Code follows all the Code Style Rules ❗️

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The implementation has a critical functional violation. The task explicitly requires data-qa="nav-hover" on the 4th nav link (Laptops & computers), but it is currently placed on the 2nd nav link (SAMSUNG). This is specified in the task requirements as a testing requirement, and automated tests will fail expecting this attribute on the 4th link. Please move the data-qa="nav-hover" attribute from the SAMSUNG link (around line 23-24) to the LAPTOPS & COMPUTERS link (around line 29-30). Additionally, several colors in _card.scss are hardcoded (#060b35, #34568b, #888, #fff) instead of using variables from _variables.scss, which violates the checklist requirement to put special colors into variables.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example ↩

  2. Re-request AI review example ↩

  3. Add AI review comments example ↩

Comment thread src/styles/_header.scss
Comment on lines +23 to +24
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates the task requirement: 'add data-qa="nav-hover" (not just hover) to the 4th nav link for testing (Laptops & computers)'. The data-qa="nav-hover" attribute is currently on SAMSUNG (2nd link) at lines 23-24, but it should be on LAPTOPS & COMPUTERS (4th link) at lines 29-30.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants