Skip to content

add task solution - #1900

Open
Pavlo-Kurchak wants to merge 2 commits into
mate-academy:masterfrom
Pavlo-Kurchak:develop
Open

add task solution#1900
Pavlo-Kurchak wants to merge 2 commits into
mate-academy:masterfrom
Pavlo-Kurchak:develop

Conversation

@Pavlo-Kurchak

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because the notifications are not setting position: absolute inline, which causes the E2E tests to fail and breaks the contract that the tests are validating. While top and right are applied, the inline style is missing position: absolute, so assertions that read element.getAttribute('style') do not see it. Please update the notification creation logic to set element.style.position = 'absolute' alongside the coordinates (e.g., element.style.top = '10px' and element.style.right = '10px'). If you currently rely on a CSS class for positioning, move that to inline styles for these elements so the tests pass. Everything else about your implementation looks solid: the title/description elements, type-specific classes, placement, and auto-hide behavior are correct. After adding the inline position, re-run the tests to confirm all three failing cases pass. Keep up the good work—this is a small but important fix to meet the task’s testing requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants